Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: tiny fix in species #26328

Closed
fchapoton opened this issue Sep 21, 2018 · 7 comments
Closed

py3: tiny fix in species #26328

fchapoton opened this issue Sep 21, 2018 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

to bypass the problem in #26327

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 07b7ba7

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26328
@fchapoton fchapoton added this to the sage-8.4 milestone Sep 21, 2018
@fchapoton
Copy link
Contributor Author

Commit: 07b7ba7

@fchapoton
Copy link
Contributor Author

New commits:

07b7ba7py3: one tiny fix in species

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26328

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Sep 21, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 21, 2018

comment:3

This isn't just a py3 fix, but brittle code overall. It should have been explicit about what basis it wants. LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 22, 2018

Changed branch from u/chapoton/26328 to 07b7ba7

@vbraun vbraun closed this as completed in 33be3b7 Sep 22, 2018
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton