Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slackware-14.2 multilib: Building iml fails #29795

Closed
mkoeppe opened this issue Jun 4, 2020 · 6 comments
Closed

slackware-14.2 multilib: Building iml fails #29795

mkoeppe opened this issue Jun 4, 2020 · 6 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 4, 2020

From https://groups.google.com/d/msg/sage-devel/WshDn3e_l3k/YInQI_-WAwAJ:

the real issue is that when building iml the libraries are hardcoded to reside at /lib, but in multilib systems this may not be the case. Specifically, in Slackware (see #29798 for slackware-multilib) we have lib for 32-bit and lib64 for 64-bit. I fixed this by changing this line in build/pkgs/iml/spkg-install.in:

SAGE_GMP_LIB="echo "$SAGE_GMP_INCLUDE" | sed 's|/include|/lib|'"

to this:

SAGE_GMP_LIB="echo "$SAGE_GMP_INCLUDE" | sed 's|/include|/lib{$LIBDIRSUFFIX}|'"

where LIBDIRSUFFIX is specified by our build to be null for 32-bit or 64 for 64-bit.

CC: @orlitzky @dimpase

Component: porting

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29795

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 4, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 4, 2020

comment:2

Indeed this code from build/pkgs/iml/spkg-install.in needs improving...

# When using GMP from a standard system location it shouldn't really
# matter what we put here, but iml's configure script requires we
# provide *something*, and this should be reasonable in most cases
SAGE_GMP_LIB="`echo "$SAGE_GMP_INCLUDE" | sed 's|/include|/lib|'`"

@mkoeppe

This comment has been minimized.

@orlitzky
Copy link
Contributor

orlitzky commented Jun 5, 2020

comment:4

Upstream IML should be smarter about detecting GMP, it just guesses at /usr/local/lib and /usr/lib by default.

To that end: it would be nice if the pkg-config file for gmp included the -L/usr/libX flag needed to link against it in the "Libs" field. But in the meantime we can probably fake it with...

$ pkg-config --variable=libdir gmp
/usr/lib64

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 24, 2021

comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 31, 2022

comment:10

outdated

@mkoeppe mkoeppe removed this from the sage-9.7 milestone Aug 31, 2022
@dimpase
Copy link
Member

dimpase commented Aug 31, 2022

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants