Document argument is_open in ManifoldSubset.complement and difference - #35040
Merged
Conversation
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35040 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 2136 2136
Lines 396142 396142
========================================
+ Hits 350948 350963 +15
+ Misses 45194 45179 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
Thank you Tobias for the review! |
mkoeppe
approved these changes
Feb 9, 2023
Member
Author
|
Thank you Matthias for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Document argument is_open of methods complement and difference in ManifoldSubset
The argument
is_openwas not documented in the docstrings ofManifoldSubset.complementandManifoldSubset.difference📝 Checklist
⌛ Dependencies