Replace \mbox by \text in manifolds#35353
Merged
Merged
Conversation
|
Documentation preview for this PR is ready! 🎉 |
egourgoulhon
approved these changes
Mar 27, 2023
egourgoulhon
left a comment
egourgoulhon
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks.
I've checked the output of the html and pdf documentation and a few Jupyter notebooks with this branch.
Member
|
Can you explain the "Deploy Documentation" failure in the automated checks? |
Contributor
Author
|
Thanks for the review. The deployment workflow is currently broken (for all PRs) and hopefully fixed with #35356. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
vscode uses katex to render the latex output of jupyter cells. However, katex doesn't support mbox (see KaTeX/KaTeX#2050). Thus we replace
\mboxwith\text.📝 Checklist
⌛ Dependencies