Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Parent in universal cyclotomic field #37091

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

fchapoton
Copy link
Contributor

using Parent for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 7163c5d; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 22, 2024
    
using `Parent` for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37091
Reported by: Frédéric Chapoton
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 24, 2024
    
using `Parent` for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37091
Reported by: Frédéric Chapoton
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
    
using `Parent` for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37091
Reported by: Frédéric Chapoton
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
    
using `Parent` for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37091
Reported by: Frédéric Chapoton
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
    
using `Parent` for the Universal Cyclotomic Field

also adding some typing annotations in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37091
Reported by: Frédéric Chapoton
Reviewer(s):
@vbraun vbraun merged commit b8fd290 into sagemath:develop Feb 2, 2024
20 checks passed
@fchapoton fchapoton deleted the parent_for_UCF branch February 3, 2024 08:21
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants