Add wrapper for FLINT's acb_dirichlet_zeta_zeros - #39391
Merged
Merged
Conversation
Contributor
Author
|
I updated the PR following a discussion with @mezzarobba |
|
Documentation preview for this PR (built with commit 0625fc1; changes) is ready! 🎉 |
mezzarobba
reviewed
Jan 28, 2025
mezzarobba
left a comment
mezzarobba
left a comment
Member
There was a problem hiding this comment.
lgtm up to some typos in the docstring
|
|
||
| def zeta_zeros(self, count, start=1): | ||
| r""" | ||
| Compute a consecutive zeros of the Riemann zeta function. |
|
|
||
| INPUT: | ||
|
|
||
| - ``count`` -- positive integer; number of zeros to be computed, must fit a machine integer |
New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.
mezzarobba
approved these changes
Jan 28, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2025
New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 31, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 3, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 4, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` New method `ComplexBallField.zeta_zeros` that wraps `acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39391 Reported by: Pierre Lairez Reviewer(s): Marc Mezzarobba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New method
ComplexBallField.zeta_zerosthat wrapsacb_dirichlet_zeta_zerosfor computing zeros of the Rieman ζ function.📝 Checklist
⌛ Dependencies