-
-
Notifications
You must be signed in to change notification settings - Fork 692
Fix test failure from #40435 #40694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failure from #40435 #40694
Conversation
|
Thanks! |
|
On my computer: I think it's because it's a |
You don't have the extension compiled. It's optional and you need to explicitly compile it ( |
|
Documentation preview for this PR (built with commit 238c7c5; changes) is ready! 🎉 |
| sage: from sage.matrix.matrix_gfpn_dense import Matrix_gfpn_dense | ||
| sage: K.<z> = GF(59) | ||
| sage: M = MatrixSpace(K, 3, 4, implementation=Matrix_gfpn_dense)(range(12)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| sage: from sage.matrix.matrix_gfpn_dense import Matrix_gfpn_dense | |
| sage: K.<z> = GF(59) | |
| sage: M = MatrixSpace(K, 3, 4, implementation=Matrix_gfpn_dense)(range(12)) | |
| sage: K.<z> = GF(25) | |
| sage: M = MatrixSpace(K, 3, 4, implementation='meataxe')(range(12)) # optional - meataxe, needs sage.rings.finite_rings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for me, it gives a AssertionError. Also, the optional - meataxe directive is not necessary as it's already present at the top of the file
Ok. Then it looks fine. |
Fixes
This isn't detected by CI as it depends on the optional meataxe package