Skip to content

PR Checklist

John Jeng edited this page Jan 30, 2017 · 1 revision

Developer Pull Request Checklist

To submit a pull request for review add the tag "PR-needs-review" to the request (and remove "PR-needs-work" if it is there).

In general (barring edge cases), PRs should meet the following before submitting for review:

  • No debugging console.log messages.
  • Any code you're introducing is actually used.
  • Non-obvious code has some sort of comments, so it's possible for somebody else to understand the code.
  • A list of exact steps on how you tested.
  • Screenshots if relevant.
Clone this wiki locally
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.