Skip to content

fix: use any for dispatcher when lib: 'dom' is used #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix: use any for dispatcher when lib: 'dom' is used #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/http-proxy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ export interface ServerOptions {
fetch?: boolean | FetchOptions;
}

export type Dispatcher = RequestInit["dispatcher"];
// use `any` when `lib: "dom"` is included in tsconfig.json,
// as dispatcher property does not exist in RequestInit in that case
export type Dispatcher = (typeof globalThis extends { onmessage: any }
? any
: RequestInit)["dispatcher"];
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional type logic has a syntax error. When accessing the dispatcher property on line 108, it's being accessed on the result of the conditional type (typeof globalThis extends { onmessage: any } ? any : RequestInit), but the parenthesis closes before ["dispatcher"] is applied.

This means you're trying to do: (ConditionalType)["dispatcher"] which attempts to access the property on the conditional type result itself. Instead, it should be:

export type Dispatcher = (typeof globalThis extends { onmessage: any }
  ? any
  : RequestInit["dispatcher"]);

Move the ["dispatcher"] access inside the false branch so it only accesses the property when RequestInit is selected.

Suggested change
: RequestInit)["dispatcher"];
: RequestInit["dispatcher"]);

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@williamstein williamstein Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(seems like nonsense by ai)


export interface FetchOptions {
/** Allow custom dispatcher */
Expand Down
Loading