Skip to content

Stephen Aghaulor saghaulor

saghaulor commented on pull request attr-encrypted/attr_encrypted#111
Stephen Aghaulor

@billymonk my original fix addressed the issue of evaluating attr_encrypted_options for class level encryption. As it stands, it doesn't appear to …

Stephen Aghaulor

It possible to use the per attribute IV and salt and not add columns. I've implemented accessors that serialize the encrypted attribute, salt, and …

saghaulor commented on pull request attr-encrypted/attr_encrypted#111
Stephen Aghaulor

@billymonk I see what you mean. The problem occurs when symbols and procs are inside of each other. Your proposed solution fixes one use case, but …

Stephen Aghaulor
  • Stephen Aghaulor 47a22eb
    Fixed conditional encryption by recursively evaluating the options.
saghaulor commented on pull request attr-encrypted/attr_encrypted#111
Stephen Aghaulor

@billymonk good point, I totally missed that. When I get a minute I'll review it closer and fix the fix.

saghaulor commented on pull request attr-encrypted/attr_encrypted#111
Stephen Aghaulor

@sbfaulkner please review and merge my pull request as it resolves issues #73 and #110

Stephen Aghaulor

@dzajic I wonder if this is related to a problem that I discovered and reported here: #110 Basically, the gem is not evaluating symbols or procs th…

Stephen Aghaulor
Stephen Aghaulor

Bump

saghaulor commented on pull request attr-encrypted/attr_encrypted#111
Stephen Aghaulor

Bump

Stephen Aghaulor
Fix conditional encryption options evaluation
2 commits with 10 additions and 0 deletions
Stephen Aghaulor
Conditional encryption incorrectly evaluates :if and :unless arguments causing conditional encryption to not work as documented.
Stephen Aghaulor
  • Stephen Aghaulor e245693
    Fixed conditional encryption by evaluating the options.
Stephen Aghaulor
  • Stephen Aghaulor 5fe92bc
    Added scrub_data method, removed useless CSV header line.
Stephen Aghaulor
  • Stephen Aghaulor 086ba29
    Switched to neobundle for conditional plugin loading.
Stephen Aghaulor

To be clear, you'll want to create a hash where you decrypt the values with the original key, because once you change the key you won't be able to …

Stephen Aghaulor

Hi @lewang, that's a great question. I myself have been tossing around potential solutions to key rotation. Perhaps we could solve the problem toge…

Stephen Aghaulor
  • Stephen Aghaulor 486ce08
    Added column names header to csv dump.
Stephen Aghaulor

I'm not sure what you mean by 'the field is populated'. Are you trying to seed data in? I'm probably missing something here, but creating a db, and…

Stephen Aghaulor

It's not clear what your'e saying. When you create your db, the encrypted columns aren't created? Or rather they are, just not the second time aro…

Stephen Aghaulor

It doesn't look like it. That's a great suggestion. You're welcome to open a pull request to add one. Do you have any ideas on how to generate one …

Stephen Aghaulor
  • Stephen Aghaulor 2e36b53
    Added Devise modules to User model.
Stephen Aghaulor
  • Stephen Aghaulor df3a017
    Updated schema to include Devise to User model.
Something went wrong with that request. Please try again.