New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formula #175

Closed
simmac opened this Issue Mar 19, 2016 · 14 comments

Comments

Projects
None yet
4 participants
@simmac

simmac commented Mar 19, 2016

It would be really cool if you could submit a rmlint formula for homebrew: https://github.com/Homebrew/homebrew/blob/master/share/doc/homebrew/Formula-Cookbook.md

This would help us OS X users

@sahib

This comment has been minimized.

Owner

sahib commented Mar 20, 2016

This would help us OS X users

Probably, but Im not a OS X user and could not test that.
We have to rely on the community for this sort of thing. This means... you!

Google found a few older formulas for rmlint 1.x, the only thing left to do would be to swap make with scons, test it and submit that (I don't know how the last thing is done).

@simmac

This comment has been minimized.

simmac commented Mar 20, 2016

Ok, I will try it. :)

@sahib

This comment has been minimized.

Owner

sahib commented Mar 20, 2016

Oh, that's a compile stop that was present in 2.4.2 (showing only BSD based systems).
I pushed a new patch release, that should have this bug fixed:

https://github.com/sahib/rmlint/releases/tag/v2.4.3

Sorry for the inconvinience.

@simmac

This comment has been minimized.

simmac commented Mar 20, 2016

Ha, I just saw the new release and deleted my comment before you sent yours, sorry.
Thanks for the patch!

@simmac

This comment has been minimized.

simmac commented Mar 20, 2016

Is there any possibility to pass the build path as an argument to scons or is it only possible to define this in the SConfig-file?

@simmac simmac changed the title from Homebrew formular to Homebrew formula Mar 20, 2016

@sahib

This comment has been minimized.

Owner

sahib commented Mar 20, 2016

Depends on what you mean by build path.
Here are the currently support variables/arguments for scons.

@simmac

This comment has been minimized.

simmac commented Mar 20, 2016

Thanks, I figured it out (the bin will be generated by rmlint in the working directory).
I just pushed my formula to homebrew (homebrew/pull/50284).

I ran into another issue described in #176 , I PR'ed the formular nevertheless because I think it is independent from the build process.

@sahib

This comment has been minimized.

Owner

sahib commented Mar 21, 2016

Cool, thank you. Hope it gets accepted.

@vitorgalvao

This comment has been minimized.

vitorgalvao commented Sep 22, 2016

@simmac Are you still working on this?

@tomhoover

This comment has been minimized.

tomhoover commented Oct 7, 2016

I just pushed a formula to homebrew. I'll comment again if/when accepted.

@sahib

This comment has been minimized.

Owner

sahib commented Oct 8, 2016

@tomhoover: Cool! Will add a note to the installation section once it's ready.

@tomhoover

This comment has been minimized.

tomhoover commented Oct 12, 2016

@sahib: the formula has now been accepted into homebrew.

Installation instructions for macOS (formerly OS X):

  1. If homebrew has not already been installed on the system, execute /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)".
  2. With homebrew installed, execute brew install rmlint.
@sahib

This comment has been minimized.

Owner

sahib commented Oct 12, 2016

I've updated the installation instructions.
Thanks for your work, @tomhoover!

@tomhoover

This comment has been minimized.

tomhoover commented Oct 16, 2016

@sahib, you're welcome! BTW- you should probably close this issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment