Fix wrong checks for username #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files touched here need a bug fix which is applied with the following patch. Signed-off-by: Stefan Weil <sw@weilnetz.de>
The variable user in struct iscsi_url is a character array, not a pointer. Therefore its address will never be NULL. When libscsi is built using clang instead of gcc, those errors are reported: iscsi-perf.c:256:17: error: comparison of array 'iscsi_url->user' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare] iscsi-dd.c:272:17: error: comparison of array 'iscsi_url->user' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare] iscsi-dd.c:331:17: error: comparison of array 'iscsi_url->user' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare] ld_iscsi.c:99:18: error: comparison of array 'iscsi_url->user' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare] Fix those errors and also similar code patterns in aros/iscsi-ls.c and test-tool/iscsi-support.c. Signed-off-by: Stefan Weil <sw@weilnetz.de>
When building on a host with installed libtool, some files are generated which should be ignored by git: examples/iscsi-dd examples/iscsiclient examples/ld_iscsi.so utils/iscsi-inq utils/iscsi-ls utils/iscsi-perf utils/iscsi-readcapacity16 utils/iscsi-swp Signed-off-by: Stefan Weil <sw@weilnetz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the 2nd patch is relevant for the bug fix, but of course all three patches may be pulled.
The first patch removes trailing blanks and was needed before further code modifications because my editor removes those blanks by default.
The 3rd patch was added to get a clean git status.
Regards
Stefan