Permalink
Browse files

Merge pull request #32 from hulu/master

[PATCH] randomize the initial rpc xid to avoid reply cache collision
  • Loading branch information...
2 parents 2738507 + a275619 commit 5ba63317aca8054280b18453790d23a448bdf92c @sahlberg committed Feb 26, 2013
Showing with 4 additions and 1 deletion.
  1. +4 −1 lib/init.c
View
5 lib/init.c
@@ -25,6 +25,7 @@
#include <string.h>
#include <stdlib.h>
#include <assert.h>
+#include <time.h>
#include "slist.h"
#include "libnfs-zdr.h"
#include "libnfs.h"
@@ -34,6 +35,7 @@
struct rpc_context *rpc_init_context(void)
{
struct rpc_context *rpc;
+ static uint32_t salt = 0;
rpc = malloc(sizeof(struct rpc_context));
if (rpc == NULL) {
@@ -59,7 +61,8 @@ struct rpc_context *rpc_init_context(void)
free(rpc);
return NULL;
}
- rpc->xid = 1;
+ rpc->xid = salt + time(NULL);
+ salt += 0x01000000;
rpc->fd = -1;
return rpc;

0 comments on commit 5ba6331

Please sign in to comment.