New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collaborating on golsp #13

Open
stamblerre opened this Issue Dec 3, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@stamblerre
Copy link

stamblerre commented Dec 3, 2018

Hi @saibing! I'm one of the people currently working on golang.org/x/tools/cmd/golsp. We recently noticed and were excited to see your work on bingo. Our plan for golsp is for it to become the official language server supported by the Go team, and the folks at Sourcegraph have agreed that they would eventually like to use our code once it is ready.

We noticed that a lot of the code in this repository is shared with golsp and with go-langserver, so we were wondering if you would be interested in collaborating with us on golsp. More information about golsp can be found through the various channels listed here. If you'd like to continue this conversation, I'm happy to talk on this issue or via email (rstambler@golang.org).

@saibing

This comment has been minimized.

Copy link
Owner

saibing commented Dec 4, 2018

@stamblerre

I am very happy to hear this news. I am also interested in collaborating with you on golsp. But I have some questions as follow:

  • How do I work with your team, and what can I do?

  • I am developing bingo in my spare time. usually on the weekend, so I can't invest full time on bingo or golsp, I don't know if it will affect the development progress of golsp.

  • I am a Chinese Gopher, I can't visit golang.org, go-review.googlesource.com at home.

my email is saibing@live.com, you can reply to me by email.

@anjmao

This comment has been minimized.

Copy link

anjmao commented Dec 4, 2018

@stamblerre My suggestion is to move golsp to golang/lsp or golang/golsp. That repository golang/tools is really annoying because:

  1. It's not possible to register new issues directly on tools repo.
  2. Source code is published to golang.org/x/tools/cmd/golsp. Why not just use github and github.com/golang/golsp url?
  3. How do you tag new releases and do versioning? Separate repo for golsp would allow to have github release tags.

I really like how easy it is to test bingo and rise new issues directly on this repo. Feedback loop is super fast.

@stamblerre

This comment has been minimized.

Copy link

stamblerre commented Dec 4, 2018

@saibing: Thanks for the quick response - I just sent you an email!

@anjmao: We will be sticking with the x/tools repo for the time being, as this is being worked on by members of the Go team. Issues can be surfaced on the https://github.com/golang/go repository. We will likely have to deal with versioning, but this is not yet a concern, since golsp is under active development and is not ready for release.

@seagle0128

This comment has been minimized.

Copy link

seagle0128 commented Dec 31, 2018

Hi guys,

I am so exciting seeing this conversation. My questions is if it's possible to merge to ONE REAL OFFICIAL LSP project? I was enjoying go-langserver but it's deprecated, then I found bingo, now golsp. Go developers really need a stable and fast langserver, like other languages. Appreciate your contributions, and I'd like contribute if possible.

@saibing

This comment has been minimized.

Copy link
Owner

saibing commented Jan 1, 2019

@seagle0128

I will invest in the development of golsp in the near future, but at present I focus on solving some problems with bingo.

@stamblerre

This comment has been minimized.

Copy link

stamblerre commented Jan 2, 2019

Our intention is for golsp to be the official Go language server implementation, supported by the Go tools team. Obviously other language servers may continue to exist, but once we officially release golsp, we will continue to actively maintain it.

@saibing saibing self-assigned this Jan 4, 2019

@saibing saibing added the question label Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment