Skip to content

chore: add service name#112

Merged
saidsef merged 1 commit into
mainfrom
k8s-service-name
Apr 10, 2025
Merged

chore: add service name#112
saidsef merged 1 commit into
mainfrom
k8s-service-name

Conversation

@saidsef
Copy link
Copy Markdown
Owner

@saidsef saidsef commented Apr 10, 2025

  • chore: add service name

@saidsef saidsef self-assigned this Apr 10, 2025
@saidsef saidsef requested a review from Copilot April 10, 2025 17:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

deployment/ingress-nginx/ingress.yml:20

  • Changing from a parameterized host ($(HOST)) to a hardcoded value may limit deployment flexibility; please verify that this change is intentional for the target environment.
+    - host: node.saidsef.co.uk

@saidsef-pr
Copy link
Copy Markdown

saidsef-pr Bot commented Apr 10, 2025

Application node-webserver-a4f31e0-112-pr-reviews has been created.

@saidsef-pr
Copy link
Copy Markdown

saidsef-pr Bot commented Apr 10, 2025

Application node-webserver-a4f31e0-112-pr-reviews is in state Running.
See more here: https://argocd.saidsef.co.uk/applications/node-webserver-a4f31e0-112-pr-reviews?operation=true

@saidsef-pr
Copy link
Copy Markdown

saidsef-pr Bot commented Apr 10, 2025

Application node-webserver-a4f31e0-112-pr-reviews is in state Succeeded.
See more here: https://argocd.saidsef.co.uk/applications/node-webserver-a4f31e0-112-pr-reviews?operation=true

@saidsef saidsef merged commit 84cab91 into main Apr 10, 2025
3 checks passed
@saidsef saidsef deleted the k8s-service-name branch April 10, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants