Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QStandardPaths instead of hard coded paths #21

Merged
merged 2 commits into from Dec 5, 2023

Conversation

dcaliste
Copy link
Collaborator

@dcaliste dcaliste commented Dec 5, 2023

Close #20

Also adjust some icon sizes, since large version are not existing for up and down.

Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaliste, wow, thanks a lot!

Side not / question: Have you addressed all hardcoded /home/nemo paths, or shall I still check if there are some remaining to be addressed?

@Olf0 Olf0 merged commit 174dad1 into sailfishos-applications:devel Dec 5, 2023
1 check failed
@dcaliste
Copy link
Collaborator Author

dcaliste commented Dec 6, 2023

Normally, I've addressed all cases. Not all old paths are now treated 1:1 with the QStandardPaths approach. I'm thinking for instance to the database location, which was previously in ~/.config/, but I've now moved it to ~/.config/flowplayer/flowplayer (the name redundancy is due to the way APP_CONFIG path is created with a style like org/app, and here the organisation is declared as flowplayer as for the application name). This latter path is compatible with Sailjail for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded paths
2 participants