Corrections to remove QtQuck.Controls and base_locations reading. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced match method in QML to, well, match county/city names in LocationCityPicker Removed unecessary QtQuick.Controls 2.2 declarations and elements.
|
Big thanks for the pull request. I'll review it. |
|
Heh. I just noticed, it seems you also play saxophone? I'm a tenor. Course, could be image compression artifacts :) |
|
Wrong instrument: not the sax, the piano for several years. |
DrYak
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the base_locations.txt reading to also cover SAILFISH,
Replaced match method in QML to, well, match county/city names in LocationCityPicker
Removed unecessary QtQuick.Controls 2.2 declarations and elements.
None of these changes should have any significant effect on other dists.