Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Document SHA1 buffer requirements more clearly
There's an inconsistency here; openconnect_set_xmlsha1() takes a redundant 'len' arg which serves no purpose except to check that the caller knows how big a SHA1 is. If it's not 41, we bail. Next time the soname is getting bumped, I'll add a similar redundant check to openconnect_get_cert_sha1() too. I should have done that when it was first converted from an internal function to a public-facing one in commit 20840ab. But I didn't, and it's not worth bumping the soname again right now *just* for that. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
- Loading branch information