New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #45
Update README.md #45
Conversation
A try to enhance the language (grammar, punctuation) and formatting of Patchmanager's README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One link needs updating, otherwise this is god, thanks Olf0
| @@ -3,25 +3,26 @@ | |||
| Patchmanager is a tool that can be used to modify the Sailfish OS user experience. | |||
| It is based on AUSMT (Auto-Update System Modification Technology), a set of scripts that enables system file patching. | |||
|
|
|||
| Patchmanager does not have application icon inside launcher. After installation Patchmanager can be found inside Settings. | |||
| Patchmanager does not have application icon on the launcher. After installation Patchmanager can be found inside Settings. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: additional space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is done on purpose:
- Background: "Modern" American English writing style is to use double space after a full stop at the end of a sentence.
- Well it is nor really that "modern", I also came across typewriter written texts from the 1940s utilising this style.
- I usually do prefer British English (spelling, grammar, style), but the double space does have a couple of advantages:
- It clearly marks the end of a sentence, because a full stop sign is also used for other purposes: "e.g. & i.e.", "etc." and other abbreviations (e.g., "approx.") etc. In case of "etc." it often is also the end of the sentence (one does not spell "etc.." then), but not necessarily so, hence using a double space or not unambiguosly marks either case.
- Especially when using monospaced fonts (from typewriters to what today is usually used for displaying source code), it makes it a lot easier to identify the end of each sentence.
- This writing style became a lot more common among nerds with the advent of emails, because back then emails always were using monospaced fonts. This still is a common style used at, e.g., the LKML (Linux Kernel Mailing List).
- For Markdown, the double spaces are only visible in the source code. When an MD file is rendered, all multiple, consecutive spaces are displayed as a single space (IIRC HTML renderers do the same).
- The original text had a some sentences followed by double spaces and some without: I merely made that consistent, deciding to use double spaces after each sentence, if another one follows.
- This MR has "Allow edits by maintainers" checked, hence you may change that, if you do not like this style of formatting the Markdown source code. But if you do that, please do it consistently throughout the whole text (there are at least three more double spaces).
If you are O.K. with this (due to the reasoning here), just hit the "Resolve conversation" button and merge.
If not, please hit the "Resolve conversation" button, adapt it as you like and merge then. Or the other way around: Hit the "Resolve conversation" button, merge and adapt as you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know all that:)
|
Sorry, I should not have explicitly re-requested a review, because you already provided one and above point can be resolved by the conversation (and "Resolve conversation" button) there: I just was too quick hitting the "Request review" button without thinking. |
|
@b100dian, as you seem to be "well on the way" / "almost there" to resurrecting the full Patchmanager 3 functionality for SailfishOS 4 and you have commit rights here at the PM3 source repo, I have a couple of questions, how you plan to proceed and how I may support that.
|
|
Hi @Olf0, I think we cross-posted around the same time.
We still need to find a way for discussing in a more 'organized' manner. |
Transifex
Well, I have a user account at Transifex and access to the "projects" as a translator for the "organisation" (in Transifex's / Atlassian's parlance) Coderus: https://www.transifex.com/coderus/ As it requires the admin role to be able to fully handle an "organisation's" projects and there can be multiple Admins for an "organisation", I kindly ask @CODeRUS to provide me with an admin role for the "organisation" Coderus at Transifex: I am willing to manage the access rights and the projects maintenance (but only at Transifex's web-frontend) of the "organisation" Coderus. My account name is also "olf" at Transifex. My first action will be to provide another person with admin rights (e.g. you, @b100dian, if you do not mind, or anybody else I trust, e.g. @Ancelad), so it does not fully depend on me being available. My second action would be to evaluate which projects at Transifex can be archived (e.g. PM2). I also started an own "organisation" olf (https://www.transifex.com/olf/) with an archived project at GitHub to "translate" (crypto-sdcard_sbj), to have a playground to see how things work, to avoid misstepping in an admin role for the "organisation" Coderus. Website https://coderus.openrepos.net/pm2 with all sub-pages
To me the dialogue you had with @CODeRUS at FSO is not conclusive (i.e., I do not really understand what Andrey's suggestion is, how to proceed): https://forum.sailfishos.org/t/contribution-required-my-orphaned-projects/6799/16 ff. Side note / idea: It would be really nice to utilise a separate GitHub project for Patchmanager's web-catalog, e.g. https://github.com/sailfishos-patches/web-catalog/ : Its README.md, a gist or its wiki could be used for list of available Patches, plus the web-catalog Patches would gain a place to file issues for them. Patchmanager developers exchange
Yes, I also pondered a bit about that and IMO made some progress:
Thus my suggestion is that I open a new thread "maemo.org → Talk → OS / Platform → SailfishOS → [Patchmanager and Patches] Developer's exchange", when I have a introduction written, which designates this new thread to developers of Patchmanager and Patches for Patchmanager. I would also denote that the old thread is still there for users of Patchmanager and issue reports for Patches from the web-catalog (because there is no other place for this; see above for an idea how to resolve this; RPM Patches have their Openrepos page for discussions / issue reports, plus often a Git{hub|lab} project with an issue tracker).
P.S.: Side note / "for something completely different" |
|
Hi @Olf0,
|
|
@SfietKonstantin, because I do want to avoid migrating the development of Patchmanager for SailfishOS to a different location, the new "Patchmanager developers team" needs permissions to fully manage this repository, plus it would be advantageous to be able to create new repositories in https://github.com/sailfishos-patches/ The much worse alternative would be to migrate the development of Patchmanager for SailfishOS to a different location (likely still at GitHub, so we can start with a "one click fork" of this repository), but this would render numerous links pointing here invalid, break context and history (provided by the sister-repos in sailfishos-patches) etc. |
|
Hello. Sorry for delay, I'm very busy on main job. I always agree with any
improvements, but still don't know anything about PM4 development progress.
Something is out of control at this moment... My nickname on TMO - Ancelad.
If you will create new forum thread - I will join to discussion. I have
some plans about transifex migration to GitHub, but still can't do it - as
I said before I work hard on main job.
чт, 16 сент. 2021 г., 00:32 Vlad G. ***@***.***>:
… Hi @Olf0 <https://github.com/Olf0>,
I'll try to answer the last part of your message for now:
- "Do you have full control over this repository" I don't have full
control, I can merge pull requests. I was planning to branch out
patchmanager3.1 - had the same idea as you (plus, pm4 is taken:) - but I
can't yet change the default branch. I consider this as a non blocker for
the goal to have openrepos 3.1 version, can be handled later.
- "What is your nickname at TMO"?
https://talk.maemo.org/member.php?u=77320 I'm on the fence about using
TMO. The new community seems to be largely on FSO now. I don't think
@nephros <https://github.com/nephros> has an account. I agree a forum
thread is the way to go.
- "O.K., if I join your Patchmanager team"? Yes! You were more terse
the last time "I am only good at shell code!" so I incorrectly thought that
you weren't "in". Nice panel of software, I've already used sfos-upgrade -
so forgive me if "I must be new here"
- "What does @nephros <https://github.com/nephros> think about this"
Let's see:)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVF55SPRS6YZ2FDARGGVNDUCDYFRANCNFSM4NWBMISQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hello @Ancelad, really nice to receive a message from you. I hope you are well, besides being overly busy. Fundamental messageDon't worry, nothing is happening in a hurry, we are glad if some of the old developers react at all. Specific detailsAndrey (Андрей Кожевников / CODeRUS) decided to stop developing for SailfishOS in his spare time, thus he ceased to maintain all his software (though he still is contracted by OMP and works on SFOS components, as far as I understand). Consequences for PatchmanagerVlad G. (b100dian / vlagged) had already started adapting Patchmanager 3.0 to SFOS 4.x (because changes in SFOS broke PM), now @nephros has also joined the new "Patchmanager developers team". I am trying to help them organisationally and am slowly preparing a new Openrepos page for PM. Patchmanager 4Its development stalled since 2018-02-19: Currently there is only a single large commit atop the codebase of PM3 back then. To me it looks like a partial rewrite in order to get rid of old, ugly code. Your patchesBTW, are you willing to test and update your patches for SFOS 4.x, when PM is running well on SFOS 4.x and you can spare a little time? AFAIU, you now have a SFOS device to test, again. And your patches have been essential (for me and many others). Further actionI will write an email to Andrey at his gmail address this weekend, which is my effort to contact him (beyond "@ mentions" here and at FSO) and ask him how we may transfer control over infrastructure (esp. Transifex), plus a couple of minor things (license etc.). |
No description provided.