Refactor and fix metadata tracking api. JB#58070 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent() is conventionally the owning QObject instance in Qt. Here it being used to that but also other needs was making it hard to follow the code. Was often mistaking references to private as references to owning object of the public instance. And then there were strange setups like parent()->parent()->something(), where the first parent was reference to another class instance private and latter parent() to its public class. Mostly mechanic changes except MprisPlayerAdaptor::minimumRate() wasn't following the pattern for some reason.
"Connected" sounds like a boolean.
Same name as in the similar structure on the following else {} branch.
The metadata object doesn't change here and it's not expected to.
Since the MprisController metaData instance was changing on different
apps to follow, qml code such as
MprisController {
metaData.onTitleChanged: console.log(metadata.title)
}
...didn't work. The connection was created for the initial metaData
instance, not updated later on.
Fixed by a separate proxy class, keeping the returned instance of
MprisController always the same. The result is a bit verbose at the
moment but it's simple. On longer run we should probably better separate
the metadata instances on media and controller apps.
Tomin1
reviewed
Jan 10, 2023
pvuorela
force-pushed
the
fix_metadata_tracking_api
branch
from
9435d8a
to
32940c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the main commit:
In addition a bunch of cleanup commits. Most notable being the one changing parent() calls to more explicit names. Was getting confused when sometimes parent was referring to qobject of the public class, or the public class owner of a private data, or private data of some other class etc.