Hide masked properties from introspection #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abranson
approved these changes
Mar 30, 2023
pvuorela
reviewed
Mar 31, 2023
[mpris] Hide masked properties from introspection. Fixes JB#59545 This implements property masking also for Introspectable interface. It relies on all adaptor classes providing static introspection xml via meta object class info. It doesn't support dynamically adding child nodes or alternative object path but those are not needed for amber-mpris. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
force-pushed
the
jb59545_introspection
branch
from
2865d9a
to
6c27751
Compare
pvuorela
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements property masking also for Introspectable interface. It relies on all adaptor classes providing static introspection xml via meta object class info. It doesn't support dynamically adding child nodes or alternative object path but those are not needed for amber-mpris.
The unfortunate thing here is that this makes a lot of 8-bit to 16-bit and 16-bit to 8-bit conversions, but I think those are impossible to avoid on Qt.