Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds with Qt 6 #24

Merged
merged 1 commit into from Jun 6, 2023
Merged

Fix builds with Qt 6 #24

merged 1 commit into from Jun 6, 2023

Conversation

Tomin1
Copy link
Member

@Tomin1 Tomin1 commented May 31, 2023

This fixes building with Qt 6 and removes all deprecation warnings as a bonus.

Main things to adapt:

  • A few places like QVariant and QDBusMetaType no longer accepted int but wanted QMetaType. That had to be ifdef'd because those versions of the methods were only introduced in Qt 6.
  • Forward declarations of Qt types are forbidden in some places.
  • Opaque pointers as property types need to be declared.
  • QVariant::type() is deprecated while QVariant::userType() is fine to use still.

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming comment, but I'll just approve already. I'm ok with either, or some new alternative.

Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
@Tomin1 Tomin1 merged commit 4a4036c into master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants