[ubu-chroot] Fix argument passing

[Thaodan]

Fix argument parsing and a few other clean ups:

• Invert Debian version check, remove Ubuntu 10.04 workaround
• Remove 'exec' command
• Sync passwd and shadow so login with su works
• Create HOME dir also if not mounting it

[sledges]

Looks good! One suggestion below.

Also it's funny how before your fix ubu-chroot -r /path/to/ubu bash -c "echo a; echo b" outputs

b

and after your fix it outputs

a
b

:)

[sledges]

While trying to test this I got su: Authentication failure when entering ubu-chroot. Rewriting with sudo did the trick:

Suggested change

	if grep --quiet \
	--invert-match \
	--word-regexp "wheezy\|jessie\|bullseye\|sid" \
	"${uburoot}"/etc/debian_version ; then
	# This is for ubuntu 12.04+ (arg quoting for sudo is different)
	echo Unknown ubuntu version >&2
	exit 1
	fi
	if [ $# -eq 0 ] ; then
	set -- /usr/bin/env \
	bash --init-file \
	/parentroot/usr/share/ubu-chroot/mer-ubusdk-bash-setup -i
	fi
	setarch x86_64 chroot "${uburoot}" \
	/usr/bin/env su -s /bin/bash -l $user -- \
	-c "$(cat <<EOF
	[ -d "$cwd" ] && cd "$cwd"
	export MERSDKUBU=1
	exec $(printf "%q " "${@}")
	EOF
	if grep --quiet \
	--invert-match \
	--word-regexp "wheezy\|jessie\|bullseye\|sid" \
	"${uburoot}"/etc/debian_version ; then
	# This is for ubuntu 12.04+ (arg quoting for sudo is different)
	echo Unknown ubuntu version >&2
	exit 1
	fi
	if [ $# -eq 0 ] ; then
	set -- /usr/bin/env \
	bash --init-file \
	/parentroot/usr/share/ubu-chroot/mer-ubusdk-bash-setup -i
	fi
	setarch x86_64 chroot "${uburoot}" \
	/usr/bin/sudo -i -u $user \
	exec bash -c "export MERSDKUBU=1; if [ -d \"$cwd\" ]; then cd \"$cwd\"; fi; exec $(printf "%q " "$@")"

The last line is the only main change, but I had to also remove the EOF again to make this suggestion into an applicable patch:)

[Thaodan]

Why do that instead of an heredoc without escaping?

[Thaodan]

While trying to test this I got su: Authentication failure when entering ubu-chroot. Rewriting with sudo did the trick:

The last line is the only main change, but I had to also remove the EOF again to make this suggestion into an applicable patch:)

pwconv should fix this, I'll look.

[sledges]

Why do that instead of an heredoc without escaping?

That worked only after I split commands with ;, because it becomes a one-liner when using this mnemonic:

setarch x86_64 chroot ${uburoot} \
        /usr/bin/sudo -i -u $user \
                exec bash -c "$(cat <<END
export MERSDKUBU=1;
[[ -d "$cwd" ]] && cd "$cwd";
exec $(printf "%q " "$@")
END
)"

[Thaodan]

That is because of the redundant exec you have there, it will spawn another shell before executing bash.

[sledges]

Removing exec still fails without ;

setarch x86_64 chroot ${uburoot} \
        /usr/bin/sudo -i -u $user \
                bash -c "$(cat <<END
export MERSDKUBU=1
[[ -d "$cwd" ]] && cd "$cwd"
exec $(printf "%q " "$@")
END
)"

$ ubu-chroot -r /path/to/ubu
bash: line 0: export: `-d': not a valid identifier
bash: line 0: export: `/home/user': not a valid identifier
bash: line 0: export: `]]': not a valid identifier
$ 

[Thaodan]

Please test gain, should be fixed now.

[sledges]

It works now thanks. I recommend to provide a safe-guard PR to dhd submodule before merging this PR.
And as you already know, after merging this PR, ubu-chroot -r /path/to/ubu "echo a; echo b" will no longer work and will require adding sh -c.

[Thaodan]

@sledges approved this pull request. It works now thanks. I recommend to provide a safe-guard PR to dhd submodule before merging this PR. And as you already know, after merging this PR, `ubu-chroot -r /path/to/ubu "echo a; echo b"` will no longer work and will require adding `sh -c`.

I added warning about changed behavior to this and some other changes like checking if --pty is supported. Please review.

[sledges]

Thank you for fixing this properly.