Update to 5.72 #11
Merged
Update to 5.72 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concept of probing not connected devices is already supported when loading devices from storage, so drivers shall already be capabable of handling such a thing as there are dedicated callbacks to indicate when there is a new connection in the form of .accept callback.
Device using private address cannot be programmed into the auto_connect list without them being paired and its IRK being distributed otherwise there is no way to resolve it address and the command will fail.
If the device is temporary restart its timer when attempt to connect to it since it can interrupt the connection attempt prematurely while it still scanning, etc.
Add function to pause (temporarily) reading data from vhci. This can be used to synchronously pause handling of btdev commands from the kernel.
bthost commands execute with a delay because events may be sitting in the socketpair queues. This makes it difficult to ensure, when writing tests, that certain bthost commands have been handled, before any new events from VHCI are processed. To make event ordering possible, add a function that flushes client bthost/btdev socketpair queues, before processing any new VHCI events. This is done by pausing VHCI input processing until the kernel socketpair queues are empty.
Simulate ACL being disconnected before SCO is established. Kernel shall not crash. eSCO ACL Disconnect - Failure Link: https://lore.kernel.org/linux-bluetooth/00000000000013b93805fbbadc50@google.com/
Simulate ACL being disconnected when connecting ISO, before LE Create CIS got sent. The kernel shall indicate connection failure for the ISO socket immediately when the ACL is gone, since connecting the ISO can no longer proceed. ISO Connect ACL Disconnect - Failure
Things like BAP depend on ISO sockets being enabled in kernel. It is possible the MGMT commands enabling experimental kernel features do not complete, before BAP etc. initialization and probing starts, in which case BAP will be mostly nonfunctional. This was observed to occur always when running BlueZ in a Fedora VM, requiring bluetoothd restart after every boot for BAP to work, log containing lines in the order: bluetoothd[981]: src/adapter.c:read_exp_features_complete() 6fbaf188-05e0-496a-9885-d6ddfdb4e03e flags 0 action 1 bluetoothd[981]: src/adapter.c:read_info_complete() index 0 status 0x00 bluetoothd[981]: profiles/audio/bap.c:bap_probe() BAP requires ISO Socket which is not enabled bluetoothd[981]: src/adapter.c:iso_socket_complete() ISO Socket successfully set Fix by waiting in adapter initialization that all MGMT exp feature requests are done, before proceeding to read adapter information. Also fix canceling MGMT_OP_SET_EXP_FEATURE for ISO sockets.
Add decoding support for Intel PPAG Enable
command.
btmon log:
< HCI Command: Intel PPAG Enable (0x3f|0x020b) plen 4
Enable: 0x00000002 (China)
> HCI Event: Command Complete (0x0e) plen 4
Intel PPAG Enable (0x3f|0x020b) ncmd 1
Status: Success (0x00)
This adds "auto" capability which behaves like "on" but instead of asking user to confirm/autorize it automatically accepts, which is not secure to be used thus a warning is printed when user selects it. Usage: [bluetoothctl]# agent auto Warning: setting auto response is not secure, it bypass user confirmation/authorization, it shall only be used for test automation. or client/bluetoothctl -a auto
This adds support for BAP broadcast sink, creates a remote endpoint when a broadcast source is discovered and synchronizes with the source upon endpoint configuration. This feature was tested using bluetoothctl with the following commands: [bluetooth]# endpoint.register 00001851-0000-1000-8000-00805f9b34fb 0x06 [bluetooth]# scan on [NEW] Endpoint /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0 [bluetooth]# endpoint.config /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0 /local/endpoint/ep0 16_2_1
This adds support for BAP broadcast sink, creates a remote endpoint when a broadcast source is discovered and synchronizes with the source upon endpoint configuration. This feature was tested using bluetoothctl with the following commands: [bluetooth]# endpoint.register 00001851-0000-1000-8000-00805f9b34fb 0x06 [bluetooth]# scan on [NEW] Endpoint /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0 [bluetooth]# endpoint.config /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0 /local/endpoint/ep0 16_2_1
This patch adds the possibility to register a broadcast media endpoint if the controller has support for ISO Sync Receiver.
This patch gets the QOS broadcast stream parameters and passes them to upper layers.
Remove unused gdbus parameter. Fix length for Codec Specific Configuration.
Fix UUID name typo.
This adds defer setup support for the Broadcast Receiver scenario. In order to create a Broadcast Receiver with the defer setup option, the -W command line parameter should be used, as described in isotest.rst.
When connecting a BAP unicast stream the followin crash can be observed: Access not within mapped region at address 0x1D4C0000000A at 0x14F759: get_bcode (transport.c:1121) by 0x1E02E4: append_property.isra.0 (object.c:498) by 0x1E03B9: append_properties (object.c:527) by 0x1E2AAB: g_dbus_get_properties (object.c:1811) by 0x14B9B6: pac_config (media.c:1130)
Commit fde32ff ("shared/gatt-client: Allow registering with NULL callback") added an early return to the notify_cb function when the current client's notify_list is empty which prevents sending confirmations to indications. Reported-by: Javier de San Pedro <dev.git@javispedro.com>
bap_create_io already handle streams of differents types.
This moves QoS related properties to a single dictionary.
This fixes the following runtime error: monitor/packet.c:10476:2: runtime error: division by zero Floating point exception
bap_io_disconnected was getting registered for all links while connecting which prevented bap_io_close to be called when ISO socket is disconnected thus the cig_active flag will remain set preventing the IO to be recreated.
Add MICS characteristic uuid(s)
- Implementation of functions related profile and service for MICS and MICP - Specifications referred for implementation: MICS - MICS_v1.0.pdf MICP - MICP_v1.0.pdf
MICP profile level interface function have been implemented This adds initial code for MICP plugin.
Fix copy of BASE from getsockopt() and update base length.
Besides OBEX root, it should be ok to push files to temporary directory. Obex root may be $HOME, but it's cleaner to have in-progress files under temporary directory.
As some carkits have trouble connecting to the default PBAP channel 15, enable channel configuration for PBAP server.
If adapter is disabled while discovering, starting the discovery again after enabling the adapter will fail unless adapters parameters are cleared as when stopping the discovery.
By 4 updates per second. Prevent Obexd from spamming DBus with "Transferred" signals when receiving a file. Co-authored-by: Jarko Poutiainen <jarko.poutiainen@jolla.com>
Makes it possible to disable autopair plugin with build-time configuration flag.
If authentication fails with MGMT_STATUS_NOT_PAIRED the device is obviosuly not connected either and we should notify of it. Also remove from the device since connection attempt is likely to fail.
Patches with bugs associated in this commit: - Add some missing tests and a tool. JB#36849 - Depend on findutils as /etc/obexd.conf requires find. JB#41628 - Use 'bluez5' for pkgconfig target. Fixes JB#36627 - Add tracing file for obexd. JB#36940 - Add package for obexd tracing. JB#36940 - Disable autopair plugin. JB#40419 - obex: Don't try to control systemd user session. Fixes JB#46633 - Split hciattach tool to own subpackage. JB#48791 - Use systemd macros to build on aarch64. JB#49681 - Enable NFC pairing. JB#54815 - Allow D-Bus activation only through systemd. JB#52572 - Don't rename bluez.pc to bluez5.spec. JB#57121 - Disable manpages building. JB#56721 Co-authored-by: Hannu Mallat <hmallat@gmail.com> Co-authored-by: Bea Lam <bea.lam@jolla.com> Co-authored-by: Pekka Vuorela <pekka.vuorela@jolla.com> Co-authored-by: Marko Saukko <marko.saukko@jolla.com> Co-authored-by: Juho Hämäläinen <juho.hamalainen@jolla.com> Co-authored-by: David Greaves <david.greaves@jolla.com> Co-authored-by: Ildar Kamaletdinov <i.kamaletdinov@omprussia.ru>
Instead of waiting for connman we can start already when D-Bus is available. Fixes JB#48911
Patches with bugs associated in this commit: - Forwards mpris control and data over Bluez. This enables music metadata over BT audio, and play/pause commands from Bluetooth devices. Fixes JB#41652 - Automatically restart mpris-proxy service if it crashes. Fixes JB#58244
Fixes build without ell. This reverts commit 1106b28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.