scripts/btrfs-balance: Eliminate BASHism #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK, [the parameter expansion in line 58 of the type "string substitution"](a9841fe#diff-491069f1965ccb0506394dca405aa76384f90d722c1e3dd4e227c28e6b002248R58) (`${parameter/pattern/string}`) is a BASHism and not supported by POSIX sh / classic Bourne Shell, dash and ash (Almquist shell). At least this is what the corresponding man pages tell.
Olf0
referenced
this pull request
May 29, 2022
Statefs is deprecated and should not be used anymore. Get battery/charger info from mce via D-Bus instead of using data under /run/state/namespaces/Battery provided by statefs. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
|
I tested the change in isolation on-device using BusyBox v1.33.1, and both the before and after versions worked perfectly (i.e. returned "on" or "off" depending on the charging state). For the reasons @Olf0 gives, I'd be in favour of accepting the change. |
llewelld
approved these changes
Jun 27, 2022
|
Just for the record: The two variants (before and after this commit) are 100% equivalent, if the Shell used supports the "before this commit" variant. For Busybox's ash this bash extension is not documented to be supported; despite that it seemed to work. Nothing I would rely on, hence this commit. Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, the parameter expansion in line 58 of the type "string substitution" (
${parameter/pattern/string}) is a BASHism and not supported by POSIX sh / classic Bourne Shell, dash and ash (Almquist shell). At least this is what the corresponding man pages tell.For more aspects and details, see a9841fe#commitcomment-74846912.