[buteo-sync-plugin-caldav] Retrieve allowed components per calendar. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvuorela
reviewed
Jun 6, 2023
src/propfind.cpp
Outdated
| /* e.g.: | ||
| <C:supported-calendar-component-set> | ||
| <C:comp name="VEVENT" /> | ||
| </C:supported-calendar-component-set> |
There was a problem hiding this comment.
Cosmetics: could indent slightly less?
There was a problem hiding this comment.
Sure, I copy pasted for some other palces where the indentation is large also, but no need to keep such space.
Use propfind method 'supported-calendar-component-set' to inquire the allowed components, like only VTODOS for task calendars for instance. These properties are not used to filter out downsynced or upsynced components yet. The information is stored to mKCal though and may be used at UI level to hide calendars not suited for VEVENT storage.
pvuorela
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use propfind method 'supported-calendar-component-set' to inquire the allowed components, like only VTODOS for task calendars for instance.
These properties are not used to filter out
downsynced or upsynced components yet. The
information is stored to mKCal though and
may be used at UI level to hide calendars
not suited for VEVENT storage.
@pvuorela, this comes out of a discussion on the forum, when using a Nextcloud account for instance, the special "Tasks" calendar is restricted for
VTODOcomponents but is listed in the calendar list page in the calendar application and in the account setting, while it is not possible to up sync any event to this calendar.https://forum.sailfishos.org/t/nextcloud-account-sync-errors-local-to-remote-remote-calendars-sync-both-ways/15791/33