Support XMPP and SIP address fields

[nephros]

This very simple change adds support for displaying "Instant Messaging" addresses in jolla-contacts/People.
No changes are required on the presentation side of things.

The result is display-only at the moment but may be used to improve support for XMPP and SIP later.

Tested with Memotoo extended contact details. See screenshots in comments below.

Example builds here

[nephros]

[llewelld]

Thanks for the PR @nephros, we could do with improvements like this.

I tried this out, but hit a few snags. The first is that X-SIP and X-JABBER seem to be non-standard, not just as indicated by their X prefix, but also in practice. So, for example, when I sync contacts from NextCloud, the SIP and XMPP fields get exported as follows:

IMPP;TYPE=SIP;VALUE=UNKNOWN:sip@example.com
IMPP;TYPE=XMPP;VALUE=UNKNOWN:xmpp@example.com

My suggestion for addressing this would be to include IMPP as well; I'm not sure whether there would be any downsides to using both.

However, the other two issues are more serious I think. Synced XMPP fields don't integrate with the underlying XMPP system. They get shown and can be copied, but can't be used to send XMPP messages using the Messaging app, unlike "real" XMPP contacts. I can see this causing confusion for users (who might rightly wonder why some XMPP addresses work but others don't).

Finally, the fields aren't integrated into the editing page, so there's no way to edit or remove them on the phone side.

My feeling is that we probably can't properly address these last two points without supporting the ability to add XMPP contacts natively. As a note-to-self, the PingYou or Shmoose might contain some good clues about how to implement this.

In the meantime, I'm torn on whether we should integrate this. The results are useful, but feel "hacky". I'd really love for this to work properly, as I accept it's useful and important functionality for some users (including myself). Is there any way it could be made less hacky without too many big changes elsewhere?

[nephros]

Thanks for your review.

The reason for choosing the X-foo tags, IIRC, was that I found somewhere in the codepaths (QtContacts? QtPIM? I don't recall) that these were already handled (mapping to the InternetMessaging type or so), while IMPP/X-IMPP was not.
So the goal of importing the addresses into the database on sync was trivially achieved by this oneliner - given that I manage contacts through memotoo and therefore have control over the export mapping.

I agree that if there is a standard and widely used tag which can encode the same information we should use that. (Although I believe both Android an iOS currently use X-Jabber for XMPP addresses - not sure about SIP.)

---

The other points about better integration into the rest of the app system - I'd love having that, but AFAICS all consumers of the imported information are Jolla proprietary components - not much can be done there from my side.

(At least nothing that wouldn't add to the "hackiness".)

[llewelld]

Thanks for explaining. I'll try to test this using the X-* tags to see whether the experience is any different for those. Just also to add that my use of "hacky" was probably not the right description; I didn't mean to denigrate your efforts.

It's possible that the issue of being able to edit the data may be relatively easy to fix, I think that's worth investigating (I'll try to look into this).

[nephros]

Just also to add that my use of "hacky" was probably not the right description; I didn't mean to denigrate your efforts.

No offense taken at all.

This effort as it stands was more of a "lets see if this works" kind of thing (a hack!) - and as it did work I thought why not make a PR see if others are interested.

Should it contribute to improving the overall situation of XMPP and SIP, great!