Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buteo-sync-plugins-social] Use default copy assignment operator for FacebookParsedEvent. JB#60722 #10

Merged
merged 1 commit into from Dec 12, 2023
Merged

[buteo-sync-plugins-social] Use default copy assignment operator for FacebookParsedEvent. JB#60722 #10

merged 1 commit into from Dec 12, 2023

Conversation

mlehtima
Copy link
Contributor

@mlehtima mlehtima commented Dec 7, 2023

No description provided.

@abranson
Copy link
Member

abranson commented Dec 8, 2023

This FB code hasn't worked for years and probably never will again. Might be better just to drop it all?

pvuorela
pvuorela approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure is the facebook stuff entirely doomed, but for compilation problems should be simpler just having this now.

Approved.

@mlehtima mlehtima merged commit 385017d into master Dec 12, 2023
@mlehtima mlehtima deleted the jb60722 branch December 12, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abranson abranson abranson approved these changes

@pvuorela pvuorela pvuorela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mlehtima @abranson @pvuorela