fetch read-only google calendars #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On quick check at least one thing missing is setting the notebook as read-only so that the user is not able to create new events on it or make modifications. Suppose that should be somewhere around GoogleCalendarSyncAdaptor::setCalendarProperties(). Did you test this yourself already? |
Not yet :-) It is late-nigh proposal, installation failed on the first attempt. But I will continue to work on that... |
|
It is working finally :-) |
Google calendar id may contain some characters that has special meaning in Url, like '#'. For example: "cs.czech#holiday@group.v.calendar.google.com". So, it is necessary to percent encode it, before usage un url.
Karry
force-pushed
the
read-only-google-calendars
branch
from
d820bdc
to
13a6b1b
Compare
pvuorela
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, I cannot see calendars of my family members shared with me as read-only. I would like to make it possible.
Not sure if this change is enough :-)