Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 3.27.1 #3

Merged
merged 2 commits into from Jul 31, 2023
Merged

Update to 3.27.1 #3

merged 2 commits into from Jul 31, 2023

Conversation

mlehtima
Copy link
Contributor

Extend cmake macros based on macros from Fedora

@mlehtima mlehtima requested a review from mkosola July 29, 2023 13:55
Thaodan
Thaodan approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe should have a test run on the obs.

Can you check the spec file? For example it use the makeinstall macro which shouldn't be used anymore?

@mlehtima
Copy link
Contributor Author

Our %make_install doesn't allow additional parameters. It's probably easiest to use %makeinstall for now, other option is to change the folder manually before running %make_install

@Thaodan
Copy link
Contributor

Thaodan commented Jul 29, 2023

Hm I guess then we can keep it. We have to fix the make_install macro but that's for another time. Maybe a todo note.

@mlehtima mlehtima merged commit 8a7c8ea into master Jul 31, 2023
@mlehtima mlehtima deleted the jb61000 branch August 19, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thaodan Thaodan Thaodan approved these changes

@mkosola mkosola mkosola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mlehtima @Thaodan @mkosola