Support Bluetooth internet sharing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
Apr 17, 2023
rainemak
reviewed
Apr 17, 2023
rainemak
reviewed
Apr 17, 2023
rainemak
reviewed
Apr 17, 2023
pvuorela
reviewed
May 22, 2023
abranson
force-pushed
the
jb60398
branch
2 times, most recently
from
76a26ac
to
980a70c
Compare
monich
reviewed
Sep 15, 2023
pvuorela
reviewed
Dec 18, 2023
pvuorela
reviewed
Dec 19, 2023
pvuorela
reviewed
Dec 19, 2023
pvuorela
reviewed
Dec 20, 2023
pvuorela
approved these changes
Dec 20, 2023
[tethering] Support Bluetooth internet sharing. Fixes JB#60398 - Enable Bluetooth tethering in connman with a persistent setting, whenever Bluetooth is powered on. It can use either mobile data or WLAN, so doesn't need to control either of those - network will be shared to connected devices whenever it's available. - Use logging category and tidy logging messages a bit - Replaced every Q_FOREACH with fors - Check tech type instead of comparing pointers - Call startTethering directly on startup. - Rename signal to 'bluetoothTetheringFinished' - Don't bail out of techChanged when wifi is not present, to check Bluetooth too - Add comment describing Bluetooth tethering behaviour - Cleanup and formatting - Stop powering on Bt when tethering is enabled. Add a comment explaining this - Renamed delayedTethering and btTetheringEnabled to tetherXWhenPowered to better describe them. They do the same thing, just wifi gets powered when tethering is enabled while Bt does not. Wifi's also gets cancelled when the connection is up, while Bt does not. - Renamed setXTethering to enableXTethering - Support stopTethering keepPowered parameter even though it's not really going to be turned off by the current UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a persistent Bluetooth tethering switch. Also clean up the logging a bit and move it to use a logging category.