[connman] Fix errors in dual index support on DNS and VPN. JB#60943 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaakkonenJussi
changed the title
LaakkonenJussi
changed the title
mlehtima
approved these changes
Jul 3, 2023
mlehtima
reviewed
Jul 4, 2023
Fix the errors caused by adding dual index support: - copy also the index of the other IP-family gw when replacing - enable searching the specific IP-family gateway - kernel netlink listens only IPv4 -> get IPv4 supporting gateway Added also more debug to certain places to ease up following what is going on. The errors caused VPN cleanups not to work and in some cases, especially with IPv6-disabling option set, VPN did not get set as default route and/or the old default route was not sent. This resulted in non-functioning networking, including disabled DNS when VPN was connected for the 2nd and ongoing times.
Tech-dependant services call default_changed() when reaching ONLINE state. Do the same with VPNs that reach READY state as VPNs cannot go ONLINE.
mlehtima
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the DNS enabling tolerant of the dual index support. Logging is now more consistent as VPN index is directly used instead of having VPN behave as tech-dependant service.
Fix the gateway setting issues which resulted in VPN not getting updated as default. Dual index support needed to be taken account in replacing and finding of the gateways.
Add also inet.c change to use RTF_HOST flag similarly to adding when removing route.
Make service.c to do default_changed() also for VPNs that reach their ultimate state (READY).