Support --data-ciphers option in OpenVPN plugin #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlehtima
approved these changes
Feb 27, 2024
|
Need to still add also support for the --data-ciphers-fallback option. It seems to be commonly used as well. |
[openvpn] Support --data-ciphers and --data-ciphers-fallback options. JB#61635 The --data-ciphers can be used with --cipher option so no need to complicate with checks that which to use. This is to address the change made to OpenVPN 2.6: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20656.html
LaakkonenJussi
force-pushed
the
jb61635
branch
from
9c01676
to
8c7cc98
Compare
mlehtima
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be apparently used with --cipher option so no need to complicate with checks that which to use.