-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tips and tricks #126
Tips and tricks #126
Conversation
12dfe6b
to
0dda35d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sound little bit odd, but very minor (line 73):
"Should you receive an error about an incorrect password or username.."
Could be: "If you receive an error.."
same with (line 333) "Should you have problems with installing.."
Could be "If you have problems.."
Some of the links are not functional:
Lines: 246, 320, 371, 377
Otherwise looks good to me.
|
1abd2e0
to
7ee854c
Compare
I have fixed what JP reported (and some more similar issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns were addressed.
please rebase on top of master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues need fixing before this can be merged
7ee854c
to
47f9426
Compare
Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
47f9426
to
0dba1e5
Compare
Done so far (commit 0dba1e5 ...):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Several ZD articles combined into Tips and Tricks. JB#58163.