Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips and tricks #126

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Tips and tricks #126

merged 1 commit into from
Oct 11, 2022

Conversation

jovirkku
Copy link
Contributor

@jovirkku jovirkku commented Oct 4, 2022

Several ZD articles combined into Tips and Tricks. JB#58163.

Copy link
Contributor

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sound little bit odd, but very minor (line 73):
"Should you receive an error about an incorrect password or username.."
Could be: "If you receive an error.."
same with (line 333) "Should you have problems with installing.."
Could be "If you have problems.."

Some of the links are not functional:
Lines: 246, 320, 371, 377

Otherwise looks good to me.

@jovirkku
Copy link
Contributor Author

jovirkku commented Oct 4, 2022

These sound little bit odd, but very minor (line 73): "Should you receive an error about an incorrect password or username.." Could be: "If you receive an error.." same with (line 333) "Should you have problems with installing.." Could be "If you have problems.."
That is another way of expressing the IF sentences (see "Conditional sentences can be made without if" at https://www.eltbase.com/notes-153-conditionals). It should be correct English. Swedish has the same thing. Anyway, no problem making those two sentences proper IF sentences - to avoid shades of meanings not so clear to us with non-English mother tongues.

Some of the links are not functional: Lines: 246, 320, 371, 377
Those relative ZD links. I was not careful enough to fix all of them. Will fix them.

Otherwise looks good to me.
Thanks

@jovirkku jovirkku force-pushed the tipsAndTricks branch 2 times, most recently from 1abd2e0 to 7ee854c Compare October 5, 2022 13:46
@jovirkku
Copy link
Contributor Author

jovirkku commented Oct 5, 2022

I have fixed what JP reported (and some more similar issues)

Copy link

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns were addressed.

@vigejolla
Copy link
Member

please rebase on top of master

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues need fixing before this can be merged

Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@jovirkku
Copy link
Contributor Author

jovirkku commented Oct 11, 2022

Done so far (commit 0dba1e5 ...):

  • title added
  • parent added
  • children removed
  • slash added to the end of permalink
    (I list the changes here as I cannot find how to handle the "unresolved conversations", some of which have "outdated")

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigejolla vigejolla merged commit e22226e into sailfishos:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants