Testing advice page #136
Merged
Testing advice page #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigejolla
reviewed
Oct 13, 2022
vigejolla
reviewed
Oct 13, 2022
vigejolla
reviewed
Oct 13, 2022
vigejolla
reviewed
Oct 13, 2022
vigejolla
reviewed
Oct 13, 2022
jovirkku
suggested changes
Oct 13, 2022
jovirkku
reviewed
Oct 13, 2022
jovirkku
reviewed
Oct 13, 2022
jpwalden
force-pushed
the
testing_advice
branch
2 times, most recently
from
e9711f6
to
cdce8e4
Compare
vigejolla
reviewed
Oct 14, 2022
|
To me this looks good, but I'll give @jovirkku a chance to verify himself that his concerns have been addressed. Please rebase on top of master. |
Signed-off-by: jari-pekka walden <jari-pekka.walden@jolla.com>
jpwalden
force-pushed
the
testing_advice
branch
from
cdce8e4
to
c13a059
Compare
vigejolla
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jari-pekka walden jari-pekka.walden@jolla.com