Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style for having one or two images in a row #138

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

vigejolla
Copy link
Member

No description provided.

@vigejolla vigejolla force-pushed the jb58966 branch 4 times, most recently from 4c19028 to afcd2a3 Compare October 13, 2022 10:49
@vigejolla vigejolla changed the title Add style for having two images in a row. JB#58966 Add style for having one or two images in a row Oct 13, 2022
Copy link
Contributor

@sledges sledges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple of non-major comments.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JB#58966

Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
@vigejolla vigejolla merged commit a0b15db into master Oct 14, 2022
@vigejolla vigejolla deleted the jb58966 branch October 14, 2022 09:12
Copy link
Contributor

@jovirkku jovirkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question on th asterisk characters in the beginning of the "a href" lines. Why use bullets there? But there was a reply that they do not make bullets appear on the final doc pages.

@vigejolla
Copy link
Member Author

I had a question on th asterisk characters in the beginning of the "a href" lines. Why use bullets there? But there was a reply that they do not make bullets appear on the final doc pages.

The reason is that we (ab)use unordered lists here. It was just an easy way of having the images and captions inside one html element, without having to actually write html. Unfortunately there's still some html left, but at least it's less than what it used to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants