Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock app #212

Merged
merged 1 commit into from Dec 16, 2022
Merged

Clock app #212

merged 1 commit into from Dec 16, 2022

Conversation

jovirkku
Copy link
Contributor

Signed-off-by: Jorma Virkkunen jorma.virkkunen@jolla.com

@jovirkku
Clock app
6bea85d 
Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
jpwalden
jpwalden approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jovirkku
Copy link
Contributor Author

jovirkku commented Dec 15, 2022 •
edited

Vibrator settings test:

CLOCK ALERT VIBRATOR ACTUAL TIMER ALERT
No sound Always Vibra
No sound Only when silent silent ???
No sound Only when sounds on Vibra ???
No sound Never silent

Verdict:

  1. "No sound" setting works correctly
  2. Vibrator settings "only when silent" and "only when sounds on" do not work as expected (i.m.h.o.)

@vigejolla vigejolla merged commit 86eef0a into sailfishos:master Dec 16, 2022
@jovirkku jovirkku deleted the clock-jb59622 branch December 19, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigejolla vigejolla vigejolla approved these changes

@jpwalden jpwalden jpwalden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jovirkku @vigejolla @jpwalden