Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email app #216

Merged
merged 1 commit into from Dec 21, 2022
Merged

Email app #216

merged 1 commit into from Dec 21, 2022

Conversation

jovirkku
Copy link
Contributor

Signed-off-by: Jorma Virkkunen jorma.virkkunen@jolla.com

jpwalden
jpwalden reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me, however there are couple of those issues Vige pointed out.

@jovirkku
Copy link
Contributor Author

An abundance of copy-paste issues. Huoh. There is one picture (pic 2) that is not "narrow".

@jovirkku
Copy link
Contributor Author

Should be ok now.

@jovirkku
Email app
a4d514f 
Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@jovirkku
Copy link
Contributor Author

Pictures 7 & 8 were put side-by-side.
Some textual references to pictures were improved.
Writing "pull-down" and "push-up" was unified with the help of Grammarly.
I think this document is now good enough.

@vigejolla vigejolla merged commit d7ddd57 into sailfishos:master Dec 21, 2022
@jovirkku jovirkku deleted the email-jb59646 branch December 21, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpwalden jpwalden jpwalden left review comments

@vigejolla vigejolla vigejolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jovirkku @vigejolla @jpwalden