CSD tests #231
Merged
CSD tests #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwalden
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Looks good to me, this is a good doc to instruct the CSD usage. Only minor note from me is from line 9 (not really worth of changing unless there is some other reason to edit the file) :
Instead of "This test tool makes it possible for the user to verify the key functions of his or her device."
I would prefer something like "This test tool makes it possible for the user to verify the key functions of their device."
vigejolla
reviewed
Jan 11, 2023
jovirkku
force-pushed
the
test_tool_CSD-jb59808
branch
from
779813e
to
148f9f3
Compare
|
All reported issues fixed. |
vigejolla
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorma Virkkunen jorma.virkkunen@jolla.com