New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Develop/HADK page #243
Conversation
|
Awesome effort to bring the layout over, but shouldn't we change the top banner to a heading, to align style with the docs? |
Sorry, I don't quite get what you are getting at. The top banner is a heading - it's just like the heading on top of every page, with the (ok, maybe not so) minor difference in style. |
|
Very nice effort indeed! Left few comments to consider regarding layout and css. |
Precisely what I meant:) Remove the styling of the grey-background banner. But I guess it's fine as it is too, because this makes the HADK page stand out, being the starting point for any porter. |
Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
|
refactored the pages so that the main layout htmls now contain mostly includes, and the minor differences between the layouts are controlled via include directive on main_content_wrap.html. I also removed the references to hadk on css class names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks @vigejolla
No description provided.