Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Develop/HADK page #243

Merged
merged 2 commits into from Jan 20, 2023
Merged

Add Develop/HADK page #243

merged 2 commits into from Jan 20, 2023

Conversation

vigejolla
Copy link
Member

No description provided.

@sledges
Copy link
Contributor

sledges commented Jan 20, 2023

Awesome effort to bring the layout over, but shouldn't we change the top banner to a heading, to align style with the docs?

@vigejolla
Copy link
Member Author

Awesome effort to bring the layout over, but shouldn't we change the top banner to a heading, to align style with the docs?

Sorry, I don't quite get what you are getting at. The top banner is a heading - it's just like the heading on top of every page, with the (ok, maybe not so) minor difference in style.

_layouts/hadk.html Outdated Show resolved Hide resolved
_layouts/hadk.html Outdated Show resolved Hide resolved
_layouts/hadk.html Outdated Show resolved Hide resolved
@rainemak
Copy link
Member

rainemak commented Jan 20, 2023

Very nice effort indeed! Left few comments to consider regarding layout and css.

@sledges
Copy link
Contributor

sledges commented Jan 20, 2023

Awesome effort to bring the layout over, but shouldn't we change the top banner to a heading, to align style with the docs?

Sorry, I don't quite get what you are getting at. The top banner is a heading - it's just like the heading on top of every page, with the (ok, maybe not so) minor difference in style.

Precisely what I meant:) Remove the styling of the grey-background banner. But I guess it's fine as it is too, because this makes the HADK page stand out, being the starting point for any porter.
And Raine is right, if we want to re-use this style for any other pages that deem so.

Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
@vigejolla
Copy link
Member Author

refactored the pages so that the main layout htmls now contain mostly includes, and the minor differences between the layouts are controlled via include directive on main_content_wrap.html. I also removed the references to hadk on css class names.

Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks @vigejolla

@vigejolla vigejolla merged commit e32f4ab into master Jan 20, 2023
3 checks passed
@rainemak rainemak deleted the jb43853 branch January 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants