Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add good quality icon #248

Merged
merged 1 commit into from Jan 24, 2023
Merged

Add good quality icon #248

merged 1 commit into from Jan 24, 2023

Conversation

vigejolla
Copy link
Member

No description provided.

Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
@sledges
Copy link
Contributor

sledges commented Jan 24, 2023

Is it intentional that this doesn't look the same as https://raw.githubusercontent.com/sailfishos/docs.sailfishos.org/master/favicon.ico ?
I like that it is square though, I wish I made the favicon.ico also square (still blue however), to match the top-left blue SFOS logo in the actual page.

@vigejolla
Copy link
Member Author

Is it intentional that this doesn't look the same as https://raw.githubusercontent.com/sailfishos/docs.sailfishos.org/master/favicon.ico ? I like that it is square though, I wish I made the favicon.ico also square (still blue however), to match the top-left blue SFOS logo in the actual page.

Kind of intentional. I didn't want to change the existing favicons, because they already look nice, and in my opinion better on my firefox tabs. On the other hand, it was explicitly mentioned in task that the icons from sailfishos.org were to be used so I used that for apple-touch-icon, which is what our browser uses.

@vigejolla vigejolla merged commit 2d848f2 into master Jan 24, 2023
4 checks passed
@vigejolla vigejolla deleted the jb59955 branch January 24, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants