Corrections to i18n docs #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sledges
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
LGTM, only commit description text:
Removed also reference to Nuance being which hinted it being a Maliit plugin
I believe the first "being" should be dropped.
for using Nuange engine.
Is Nuange -- a Nuance's engine, or a typo? The only place I found meniton of both is:..
https://archive.org/stream/Personal_Computer_World_2009-06_VNU_Business_Publications_GB/Personal_Computer_World_2009-06_VNU_Business_Publications_GB_djvu.txt
Bokmål and Sanskrit are languages, not scripts. Removed those and added the ones we have font support for. All except thai and arabic have also input support. Removed also reference to Nuance which is hinted being a Maliit plugin. That's incorrect, the jolla-keyboard is a maliit plugin and jolla-keyboard internally has pluggable support for using the Nuance engine. Signed-off-by: Pekka Vuorela <pekka.vuorela@jolla.com>
pvuorela
force-pushed
the
i18n_corrections
branch
from
8ece82d
to
e8a84c9
Compare
|
Yep, latter Nuange was a typo. Adjusted that and the other mentioned bad wording. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokmål and Sanskrit are languages, not scripts. Removed those and added the ones we have font support for. All except thai and arabic have also input support.
Removed also reference to Nuance being which hinted it being a Maliit plugin. That's incorrect, the jolla-keyboard is a maliit plugin and jolla-keyboard internally has pluggable support for using Nuange engine.
Signed-off-by: Pekka Vuorela pekka.vuorela@jolla.com