Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firewall description from ZenDesk #255

Merged
merged 1 commit into from Feb 9, 2023
Merged

Add Firewall description from ZenDesk #255

merged 1 commit into from Feb 9, 2023

Conversation

LaakkonenJussi
Copy link
Contributor

Moved https://jolla.zendesk.com/hc/en-us/articles/360017800813-Firewall-in-Sailfish-OS to forum format. Also updated any outdated or wrong info on the page.

vigejolla
vigejolla requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure the content itself is fine, but those lists need a little bit of finetuning

@LaakkonenJussi
Copy link
Contributor Author

I'm sure the content itself is fine, but those lists need a little bit of finetuning

Thanks. I'll squash after approval.

vigejolla
vigejolla requested changes Feb 7, 2023
View reviewed changes
Support/Help_Articles/Firewall/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Firewall/README.md Outdated Show resolved Hide resolved
vigejolla
vigejolla approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nitpick still though: There should be a space between "Sailfish" and "OS" in "Sailfish OS Forum"

jpwalden
jpwalden approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@LaakkonenJussi
Copy link
Contributor Author

LGTM, one nitpick still though: There should be a space between "Sailfish" and "OS" in "Sailfish OS Forum"

Ah yeah, minor issue but sedable ;). Done.

@LaakkonenJussi LaakkonenJussi merged commit b3e160c into sailfishos:master Feb 9, 2023
4 checks passed
@LaakkonenJussi LaakkonenJussi deleted the firewall_from_zendesk branch February 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigejolla vigejolla vigejolla approved these changes

@jpwalden jpwalden jpwalden approved these changes

@jovirkku jovirkku Awaiting requested review from jovirkku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LaakkonenJussi @vigejolla @jpwalden