Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the script 'Collect persistent logs' #258

Merged

Conversation

jovirkku
Copy link
Contributor

@jovirkku jovirkku commented Feb 8, 2023

Signed-off-by: Jorma Virkkunen jorma.virkkunen@jolla.com

Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@jovirkku
Copy link
Contributor Author

jovirkku commented Feb 8, 2023

Update the script from v.3 to v.4.
This is to ensure that the script matches AppSupport v.11.

It is known that lxc-attach, when running the script, prints out some warnings on 4.5.0 while on 4.6.0 it does not. It works correctly, though. Those warnings will fade away later when 4.6.0 gets published.

The author of the script is Juho. The script is actually kept in GitHub. Our document has it attached. Should we use a direct link rather than updating the script here every now and then?

Copy link
Member

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understood this is ok.

@jusa
Copy link
Member

jusa commented Feb 8, 2023

If I knew the script was here I would have updated it directly here as well.. :) So ok for me to have it here, in the future I will modify this one directly.

@vigejolla vigejolla merged commit 35b7405 into sailfishos:master Feb 8, 2023
4 checks passed
@jovirkku jovirkku deleted the updateScriptPersistentLogs-jb60116 branch February 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants