Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API, BSP and kernel columns #260

Merged

Conversation

jovirkku
Copy link
Contributor

Signed-off-by: Jorma Virkkunen jorma.virkkunen@jolla.com

@jovirkku
Copy link
Contributor Author

I was unable to add 7 columns to the table as the MD system of GitHub is forcing 6 equally wide columns. I also tried to make an HTML table with attributes style width="100%" but even that did not work for me. So much time wasted.

Therefore, I used a trick.

Copy link
Member

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jovirkku
Copy link
Contributor Author

jovirkku commented Feb 11, 2023 via email

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting for that kernel version change before merging

@jovirkku jovirkku force-pushed the updateSupportedDeviceDetails-jb60077 branch from 4336228 to 444dcfd Compare February 13, 2023 07:59
@jovirkku
Copy link
Contributor Author

One more change coming up...

Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@jovirkku jovirkku force-pushed the updateSupportedDeviceDetails-jb60077 branch from 444dcfd to 1501de5 Compare February 13, 2023 10:20
@jovirkku
Copy link
Contributor Author

Change requests of Marko Saukko implemented.

@vigejolla vigejolla merged commit 487cdba into sailfishos:master Feb 13, 2023
4 checks passed
@jovirkku jovirkku deleted the updateSupportedDeviceDetails-jb60077 branch February 13, 2023 11:22
@attah
Copy link

attah commented Feb 13, 2023

Isn't it misleading to have AppSupport version in the same table?
People keep getting confused and think it is (closely) related to the prerequisite Android version... This won't help with that.

@vigejolla
Copy link
Member

Isn't it misleading to have AppSupport version in the same table? People keep getting confused and think it is (closely) related to the prerequisite Android version... This won't help with that.

I think it might help. When people see that AppSupport version, required Android version and BSP version for a given device have three different numbers, they might realize that they are different things. The descriptions below the table could be improved though - PRs are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants