Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release 4.5.0.19 to the table of releases #296

Merged
merged 1 commit into from Mar 21, 2023

Conversation

jovirkku
Copy link
Contributor

No description provided.

@jovirkku
Copy link
Contributor Author

This PR adds the latest 4.5.0 hotfix to the table of releases.

A concern: The table has the latest ID (4.5.0.19) but the date of the 1st 4.5.0 release (4.5.0.16).
Do we want to
a) change the date to 2023-03-20, or
b) shorten the ID to 4.5.0 and show the date of the latest hotfix
c) list all 4.5.0 releases separately
d) something else, what?
Personally, I would select option b).

Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@vigejolla
Copy link
Member

This PR adds the latest 4.5.0 hotfix to the table of releases.

A concern: The table has the latest ID (4.5.0.19) but the date of the 1st 4.5.0 release (4.5.0.16). Do we want to a) change the date to 2023-03-20, or b) shorten the ID to 4.5.0 and show the date of the latest hotfix c) list all 4.5.0 releases separately d) something else, what? Personally, I would select option b).

I think the option b is the worst, because the information it provides is clearly wrong. If we show the ID as "4.5.0", the release date should be the release date of 4.5.0 and not some hotfix. But anyway, merging this as is now, let's continue this discussion elsewhere.

@vigejolla vigejolla merged commit a2ebe7e into sailfishos:master Mar 21, 2023
4 checks passed
@jovirkku jovirkku deleted the addNewRelease-jb60415 branch March 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants