New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repo command and patch error clarifications to Xperia 10 III build page #36
Conversation
Develop/HW_Adaptation/Sailfish_X_Xperia_Android_11_Build_and_Flash/README.md
Show resolved
Hide resolved
Develop/HW_Adaptation/Sailfish_X_Xperia_Android_11_Build_and_Flash/README.md
Outdated
Show resolved
Hide resolved
Develop/HW_Adaptation/Sailfish_X_Xperia_Android_11_Build_and_Flash/README.md
Outdated
Show resolved
Hide resolved
Develop/HW_Adaptation/Sailfish_X_Xperia_Android_11_Build_and_Flash/README.md
Outdated
Show resolved
Hide resolved
9ef8603
to
e0518dd
Compare
0b2b7f4
to
01f7d51
Compare
|
Rebased; commit title and summary updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move bug#ref from commit message (subject) to anywhere as stand-alone in the commit description.
01f7d51
to
e901d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good to me however the commit message is over 80 character wide I don't think that's good.
It's not so uncommon in this repo. |
|
There is upstream history (e842498) which really contains long summaries, but our own commits are all under 80 :) |
…d page jb#57393 Adds in some comments to clarify a couple of points: 1. Installing the repo command. 2. Ignoring errors when applying patches.
Okay. |
e901d27
to
19b4d12
Compare
Propagating changes from #36 Signed-off-by: Simonas Leleiva <simonas.leleiva@jolla.com>
Propagating changes from #36 Signed-off-by: Simonas Leleiva <simonas.leleiva@jolla.com>
When following these instructions I hit some practical issues:
sudoin the Ubuntu Chroot.repocommand missing.pkgconfig(audiosystem-passthrough).I've added some suggested changes for working around the errors or explaining that the errors can be ignored.