Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo command and patch error clarifications to Xperia 10 III build page #36

Merged
merged 1 commit into from Feb 10, 2022

Conversation

llewelld
Copy link
Member

@llewelld llewelld commented Feb 7, 2022

When following these instructions I hit some practical issues:

  1. Couldn't gain sudo in the Ubuntu Chroot.
  2. repo command missing.
  3. Failed build dependency pkgconfig(audiosystem-passthrough).
  4. Errors when applying patches.
  5. Missing commands for building droid-hal etc.

I've added some suggested changes for working around the errors or explaining that the errors can be ignored.

@llewelld llewelld changed the title Update instructions with fixes and workaround Update Xperia 10 III build instructions with fixes and workaround Feb 7, 2022
@llewelld llewelld changed the title Update Xperia 10 III build instructions with fixes and workaround Add repo command and patch error clarifications to Xperia 10 III build instructions. JB#57393 Feb 9, 2022
@llewelld llewelld force-pushed the xperia10iii-build-01 branch 2 times, most recently from 0b2b7f4 to 01f7d51 Compare February 9, 2022 13:43
@llewelld
Copy link
Member Author

llewelld commented Feb 9, 2022

Rebased; commit title and summary updated.

Copy link
Contributor

@sledges sledges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move bug#ref from commit message (subject) to anywhere as stand-alone in the commit description.

@llewelld llewelld changed the title Add repo command and patch error clarifications to Xperia 10 III build instructions. JB#57393 Add repo command and patch error clarifications to Xperia 10 III build instructions Feb 9, 2022
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me however the commit message is over 80 character wide I don't think that's good.

@llewelld
Copy link
Member Author

llewelld commented Feb 9, 2022

The text looks good to me however the commit message is over 80 character wide I don't think that's good.

It's not so uncommon in this repo.

$ git log --oneline | grep -E ".{88,}" | wc -l
53

@martyone
Copy link
Member

martyone commented Feb 9, 2022

There is upstream history (e842498) which really contains long summaries, but our own commits are all under 80 :)

…d page

jb#57393

Adds in some comments to clarify a couple of points:

1. Installing the repo command.
2. Ignoring errors when applying patches.
@llewelld
Copy link
Member Author

llewelld commented Feb 9, 2022

There is upstream history (e842498) which really contains long summaries, but our own commits are all under 80 :)

Okay.

@llewelld llewelld changed the title Add repo command and patch error clarifications to Xperia 10 III build instructions Add repo command and patch error clarifications to Xperia 10 III build page Feb 9, 2022
@sledges sledges merged commit 8726b4d into master Feb 10, 2022
sledges added a commit that referenced this pull request Feb 11, 2022
Propagating changes from #36

Signed-off-by: Simonas Leleiva <simonas.leleiva@jolla.com>
sledges added a commit that referenced this pull request Feb 23, 2022
Propagating changes from #36

Signed-off-by: Simonas Leleiva <simonas.leleiva@jolla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants