Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser logging instructions moved to browser dev #53

Merged
merged 1 commit into from Mar 25, 2022

Conversation

rainemak
Copy link
Member

Browser logging instructions moved to browser development aka working with browser page.

Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a small suggestion, but alongside #52 this looks good.

Reference/Core_Areas_and_APIs/Browser/README.md Outdated Show resolved Hide resolved
@rainemak
Copy link
Member Author

@llewelld squashed your change and amended "Co-authored-by: David Llewellyn-Jones david.llewellyn-jones@jolla.com" to the commit.

Browser logging instructions moved to browser development aka working with browser page.

Co-authored-by: David Llewellyn-Jones <david.llewellyn-jones@jolla.com>
@rainemak
Copy link
Member Author

Rebased

Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Co-authored" is overstating it just a bit :D (do feel free to drop that). But, that aside, this LGTM.

@rainemak rainemak merged commit 7da690b into master Mar 25, 2022
@rainemak rainemak deleted the rainemak-logging-cleanup branch March 25, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants