Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct indention #55

Merged
merged 1 commit into from Apr 13, 2022
Merged

Set correct indention #55

merged 1 commit into from Apr 13, 2022

Conversation

pherjung
Copy link
Contributor

download is described as method, without indentation it's a function.

llewelld
llewelld requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pherjung. The changes you've suggested all look good, but I think it would make sense to fix the incorrect indentation in the few lines above at the same time, if that would be okay?

Develop/Apps/Tutorials/Creating_an_application_in_Python/README.md Outdated Show resolved Hide resolved
@pherjung
Set correct indention
4cdafa9 
download is described as method, without indentation it's a function.

Indent correctly python code
llewelld
llewelld approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, many thanks! This looks good to me now.

@rainemak rainemak merged commit c59d867 into sailfishos:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martyone martyone martyone approved these changes

@llewelld llewelld llewelld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pherjung @martyone @llewelld @rainemak