Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sailfish Platform SDK to the Tools navigation bar #76

Merged
merged 3 commits into from May 6, 2022

Conversation

rainemak
Copy link
Member

@rainemak rainemak commented May 5, 2022

This PR contains two commits. First one adds "Sailfish Platform SDK" to the side navigation bar of the Tools. Second commit renames "Platform SDK" to "Sailfish Platform SDK".

Before this change "Platform SDK" was well hidden behind HADK section of the Tools.

See JB#58068

Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
@rainemak rainemak requested review from sledges and llewelld May 5, 2022 11:57
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, I honestly couldn't find the link to the Platform SDK without examining the diff here. So this definitely makes it clearer. The consistency change Platform SDK -> Sailfish Platform SDK also looks good to me.

I just wonder if it's worth adding a very short section to Tools/README.md between "Sailfish SDK" and "Sailfish HADK", just to clarify what the Sailfish Platform SDK is. Just a suggestion, as this change is fine as it is already as far as I'm concerned.

Sailfish Platform SDK

The Sailfish Platform SDK provides a similar integrated development environment to the Sailfish SDK, but targetted at developing the Sailfish OS operating system components rather than Sailfish OS applications.

@rainemak
Copy link
Member Author

rainemak commented May 5, 2022

The Sailfish Platform SDK provides a similar integrated development environment to the Sailfish SDK, but targetted at developing the Sailfish OS operating system components rather than Sailfish OS applications.

This is good suggestion. Will amend this there.

Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
@rainemak rainemak merged commit 0c262b1 into master May 6, 2022
@rainemak rainemak deleted the jb58068_platform_sdk branch May 6, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants